Iterate UI for AI job modal #7368

knollengewaechs · 2023-10-05T15:23:00Z

Steps to test:

set isWkorgInstance and jobsEnabled to true in application.conf
open annotation and click "AI analysis" button. click through the modal.
make sure its working in the same cases as before, such as when viewing a dataset as a superuser
make sure the "Merge this volume annotation with its fallback layer" in the context menu of a segment layer is still working.
NB: it seemed not to be working before and still isnt, at least for me. its probably important to test this in depth during review 😅

TODOs:

Issues:

fixes Iterate on UI for AI features #7268

(Please delete unneeded items, merge only when none are left open)

Updated changelog
Updated documentation if applicable
Removed dev-only changes like prints and application.conf edits
Considered common edge cases

knollengewaechs · 2023-10-05T15:25:28Z

conf/application.conf

@@ -130,11 +130,11 @@ features {
  discussionBoard = "https://forum.image.sc/tag/webknossos"
  discussionBoardRequiresAdmin = false
  hideNavbarLogin = false
-  isWkorgInstance = false


knollengewaechs · 2023-10-05T15:26:07Z

frontend/javascripts/oxalis/view/action-bar/starting_job_modals_old.tsx

@@ -26,7 +26,7 @@ import { clamp, computeArrayFromBoundingBox, rgbToHex } from "libs/utils";
 import { getBaseSegmentationName } from "oxalis/view/right-border-tabs/segments_tab/segments_view_helper";
 import { V3 } from "libs/mjs";
 import { ResolutionInfo } from "oxalis/model/helpers/resolution_info";
-import { isBoundingBoxExportable } from "../action-bar/download_modal_view";


remove class before merging

daniel-wer

Great work and implementation of the mockup! I only left some small comments during the review. Please also see my notes from testing:

Trying to open the modal in an annotation with only a segmentation layer, I get a
```
TypeError: Cannot use 'in' operator to search for 'tracingId' in undefined
  at getReadableNameOfVolumeLayer (starting_job_modals.tsx:90:10)
  at StartJobForm (starting_job_modals.tsx:531:44)
```
If none of the processing jobs make sense without a color layer, the "AI Analysis" button should probably be disabled and have a tooltip explaining that.
Since the modal requires to select a bounding box and creating bounding boxes is not possible when viewing a dataset, the "AI Analysis" functionality cannot be used when viewing a dataset at the moment. Maybe there should always be an option to use the full bounding box? This way, the functionality could at least be used when viewing small datasets.
[Minor] The images are 500x500 px² (~600 kb), but are displayed much smaller (150x150 px²) which is only ~10% (~35% on hi-res). It might make sense to provide a smaller variant. However, this might be a general issue in our code-base and it might make sense to investigate and fix this in general as part of a separate issue.
Also, has been like this before, but when there are multiple color layers, the label for the layer selection simply reads "color". Could you please replace this with "Layer" (since the placeholder already reads "Select a color layer")
The volume annotation materialization functionality also doesn't work for me (doesn't do anything when clicking the button). I'll have a look at what's the issue with that.

frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx

The required property of this rule was misleading since it is not required if a bounding box cannot be configured, but in addition seems to be ignored if a validator is set. Thus in the validator one needs to make sure to avoid letting the validation fail if a bounding box cannot be configured. Also improve validation messages for bounding box selection form item.

daniel-wer · 2023-10-10T17:50:43Z

@dieknolle3333 I should have fixed the volume annotation materialization functionality, at least the job is triggered for me, again. Would be great if you could check as well :) The issue was a form validation regression introduced in #7357.

knollengewaechs · 2023-10-16T15:24:36Z

@daniel-wer I tried to test the volume annotation materialization, and I just wanted to make sure that this toast is expected in my case.

Before you fixed it, nothing happened at all.

Thank you for looking into this so quickly!

daniel-wer · 2023-10-17T15:07:57Z

I tried to test the volume annotation materialization, and I just wanted to make sure that this toast is expected in my case.

Yes, that's expected :)

frontend/javascripts/oxalis/view/action_bar_view.tsx

knollengewaechs · 2023-10-18T09:27:33Z

I downsampled the images – maybe we have to fix the sizing for more pictures later on, but I shouldn't worsen the problem 😀

knollengewaechs · 2023-10-18T11:39:02Z

@daniel-wer I think and hope that I addressed all of your feedback :)

daniel-wer

Great work, was a pleasure to look at and use. I only left two small suggestions :)

daniel-wer · 2023-10-18T13:32:30Z

docs/automated_analysis.md


-You can launch the nuclei inferral from the `Menu` dropdown in the action bar at the top. Use the `Start AI analysis` link to start the analysis.
+You can launch the neuron segmentation from the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.


Suggested change

You can launch the neuron segmentation from the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.

You can launch the AI analysis modal using the button in the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.

frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx

knollengewaechs · 2023-10-19T09:21:22Z

thank you for the considerate review!

knollengewaechs added 7 commits September 29, 2023 22:16

WIP: renew ai job modal

5640d14

trying out radio buttons but probably discarding

cd6d3d9

style radio button using card

eeaf452

update store with new action

282c56f

Merge branch 'master' into ai-job-modal

9e5faa2

not pretty but working: first version of full modal

11b9029

improve code structure

39a822a

knollengewaechs commented Oct 5, 2023

View reviewed changes

knollengewaechs added 12 commits October 6, 2023 15:57

use type for ai job modal state

9444b4d

WIP: reintroduce description

157c19b

style disclaimer

ad6e369

WIP: improve spacing

3b0b9ef

remove dev remnants and style modal some more

6fd003d

refactor code

29ad42e

improve styling and design

7d3abc5

trying to fix materialize volume modal

eae3b0d

Merge branch 'master' into ai-job-modal

93f6407

fix materialize volume annotation

1ca1565

add changelog and rename

254d395

improve start modal state, rename classes

19369ef

knollengewaechs requested a review from daniel-wer October 10, 2023 09:14

knollengewaechs marked this pull request as ready for review October 10, 2023 09:15

knollengewaechs mentioned this pull request Oct 10, 2023

change docs for ai processing jobs #7373

Merged

daniel-wer reviewed Oct 10, 2023

View reviewed changes

philippotto assigned knollengewaechs Oct 11, 2023

address code review

268e3de

improve select title

ca8295c

knollengewaechs added 2 commits October 17, 2023 21:00

diable AI button without color layer and propose whole-layer-bb

7a94d35

merge master

013f50f

daniel-wer reviewed Oct 18, 2023

View reviewed changes

frontend/javascripts/oxalis/view/action_bar_view.tsx Outdated Show resolved Hide resolved

format code and remove comment

6d70123

knollengewaechs added 2 commits October 18, 2023 11:31

downsample images

2f92e49

chnage docs

be1d657

daniel-wer approved these changes Oct 18, 2023

View reviewed changes

knollengewaechs added 2 commits October 19, 2023 11:19

improve wording in docs and always propose whole layer bounding box

19e12fd

Merge branch 'master' into ai-job-modal

83fc117

knollengewaechs added 4 commits October 23, 2023 12:07

merge master

985fec0

lint

b886458

remove wrapper

334d9ba

Merge branch 'master' into ai-job-modal

4725215

knollengewaechs enabled auto-merge (squash) October 23, 2023 11:53

knollengewaechs merged commit cba39c7 into master Oct 23, 2023
1 check passed

knollengewaechs deleted the ai-job-modal branch October 23, 2023 12:09

fm3 mentioned this pull request Nov 15, 2023

Add form item to enter the name of the output segmentation layer for the inferral jobs #6197

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iterate UI for AI job modal #7368

Iterate UI for AI job modal #7368

knollengewaechs commented Oct 5, 2023 •

edited

Loading

knollengewaechs Oct 5, 2023

knollengewaechs Oct 5, 2023

daniel-wer left a comment •

edited by knollengewaechs

Loading

daniel-wer commented Oct 10, 2023

knollengewaechs commented Oct 16, 2023 •

edited

Loading

daniel-wer commented Oct 17, 2023

knollengewaechs commented Oct 18, 2023

knollengewaechs commented Oct 18, 2023

daniel-wer left a comment

daniel-wer Oct 18, 2023

knollengewaechs commented Oct 19, 2023


		You can launch the nuclei inferral from the `Menu` dropdown in the action bar at the top. Use the `Start AI analysis` link to start the analysis.
		You can launch the neuron segmentation from the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.

	You can launch the neuron segmentation from the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.
	You can launch the AI analysis modal using the button in the action bar at the top. Use the `Start AI neuron segmentation` button in the modal to start the analysis.

Iterate UI for AI job modal #7368

Iterate UI for AI job modal #7368

Conversation

knollengewaechs commented Oct 5, 2023 • edited Loading

Steps to test:

TODOs:

Issues:

knollengewaechs Oct 5, 2023

Choose a reason for hiding this comment

knollengewaechs Oct 5, 2023

Choose a reason for hiding this comment

daniel-wer left a comment • edited by knollengewaechs Loading

Choose a reason for hiding this comment

daniel-wer commented Oct 10, 2023

knollengewaechs commented Oct 16, 2023 • edited Loading

daniel-wer commented Oct 17, 2023

knollengewaechs commented Oct 18, 2023

knollengewaechs commented Oct 18, 2023

daniel-wer left a comment

Choose a reason for hiding this comment

daniel-wer Oct 18, 2023

Choose a reason for hiding this comment

knollengewaechs commented Oct 19, 2023

knollengewaechs commented Oct 5, 2023 •

edited

Loading

daniel-wer left a comment •

edited by knollengewaechs

Loading

knollengewaechs commented Oct 16, 2023 •

edited

Loading