Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic change of natively rendered layer (by re-applying transforms) #7246

Merged
merged 28 commits into from
Aug 14, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 3, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open C555_DIAMOND_2f-TPS on the dev instance
  • use the new transform-toggle-buttons next to the layers
  • the position and zoom should adapt when using the toggle button so that one stays roughly in the same area
  • create an annotation
  • volume annotation should only be possible when the volume layer is not transformed

TODOs:

  • test TPS and affine chaining further
  • adapt position when toggling transforms
  • adapt zoom when toggling transforms ?
  • todo-comments / refactor source/target name mismatch

Issues:

  • contributes to #6926

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Updated documentation if applicable
  • Removed dev-only changes like prints and application.conf edits

@philippotto philippotto self-assigned this Aug 3, 2023
@philippotto philippotto requested a review from daniel-wer August 8, 2023 09:44
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manage to review a lot, but will continue tomorrow :)

frontend/javascripts/libs/multi_key_map.ts Outdated Show resolved Hide resolved
frontend/javascripts/libs/thin_plate_spline.ts Outdated Show resolved Hide resolved
frontend/javascripts/libs/utils.ts Outdated Show resolved Hide resolved
@philippotto philippotto changed the title [WIP] Allow dynamic change of natively rendered layer (by re-applying transforms) Allow dynamic change of natively rendered layer (by re-applying transforms) Aug 9, 2023
@philippotto
Copy link
Member Author

@daniel-wer I think the PR is ready for a complete review. There was some inverted source<>target semantics in the code which was a bit annoying to clean up. I would recommend to not review commit-by-commit, since lots of changes cancelled out (e.g., I renamed source and target and then swapped the order in another commit + some bug fixes where it was simply wrong). I hope this doesn't complicate the review vastly 🙏

@philippotto philippotto requested a review from normanrz August 10, 2023 09:50
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@philippotto philippotto enabled auto-merge (squash) August 14, 2023 07:47
@philippotto philippotto merged commit fda44f4 into master Aug 14, 2023
@philippotto philippotto deleted the toggle-transforms branch August 14, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants