-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic change of natively rendered layer (by re-applying transforms) #7246
Conversation
… transform on click
…ts affine-only-inverses currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not manage to review a lot, but will continue tomorrow :)
@daniel-wer I think the PR is ready for a complete review. There was some inverted source<>target semantics in the code which was a bit annoying to clean up. I would recommend to not review commit-by-commit, since lots of changes cancelled out (e.g., I renamed source and target and then swapped the order in another commit + some bug fixes where it was simply wrong). I hope this doesn't complicate the review vastly 🙏 |
…licking button should be no-op
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff!
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)