Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix true brush size for small, uneven brush sizes #7129

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Fix true brush size for small, uneven brush sizes #7129

merged 2 commits into from
Jun 8, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 8, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create annotation
  • use brush with different sizes and test that the preview is equal to the actually painted area

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jun 8, 2023
@philippotto philippotto requested a review from fm3 June 8, 2023 09:51
fm3
fm3 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) Thanks!

@philippotto philippotto enabled auto-merge (squash) June 8, 2023 11:36
@philippotto philippotto merged commit aae1506 into master Jun 8, 2023
@philippotto philippotto deleted the fix-true-brush branch June 8, 2023 11:36
hotzenklotz added a commit that referenced this pull request Jun 9, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into red…
10df37c 
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  Fix true brush size for small, uneven brush sizes (#7129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@philippotto philippotto

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brush preview can be imprecise
2 participants
@philippotto @fm3