Fix rare crash when viewing shared annotation #6892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the first place if it's not allowed
philippotto
commented
Mar 2, 2023
philippotto
commented
Mar 2, 2023
…-crash-in-shared-annotation
…e (not necessary anymore since we ditched Flow)
MichaelBuessemeyer
approved these changes
Mar 9, 2023
Comment on lines
+1
to
+13
| import type { OxalisState } from "oxalis/store"; | ||
|
|
||
| export function mayEditAnnotationProperties(state: OxalisState) { | ||
| const { owner, restrictions } = state.tracing; | ||
| const activeUser = state.activeUser; | ||
|
|
||
| return !!( | ||
| restrictions.allowUpdate && | ||
| restrictions.allowSave && | ||
| activeUser && | ||
| owner?.id === activeUser.id | ||
| ); | ||
| } |
hotzenklotz
added a commit
that referenced
this pull request
Mar 9, 2023
…alized_format * 'master' of github.com:scalableminds/webknossos: Fix rare crash when viewing shared annotation (#6892)
hotzenklotz
added a commit
that referenced
this pull request
Mar 13, 2023
…come_header_UI * 'master' of github.com:scalableminds/webknossos: Fix rare crash when viewing shared annotation (#6892)
hotzenklotz
added a commit
that referenced
this pull request
Mar 13, 2023
…pdown-menu * 'master' of github.com:scalableminds/webknossos: Avoid SQL error when fetching view config for zero-layer dataset (#6912) Fix date formatting for VX reports (#6908) Fix rare crash when viewing shared annotation (#6892) Slim down view mode dropdown by using icons (#6900) Logging on password reset/change (#6901) When merging volume tracings, also merge segment lists (#6882) avoid spinner when switching tabs in dashboard (#6894)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user (who is not the owner) views a shared annotation, editing the layer settings will cause failed edit-annotation requests. After several retries (will take 5 minutes and new edits will reset the timer), the sagas will crash since the user is not allowed to edit annotation properties (only the tracings itself may be changed).
The PR fixes this by:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)