Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basicauth for exploring remote http datasets #6866

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix basicauth for exploring remote http datasets #6866

merged 2 commits into from
Feb 21, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 21, 2023

The credentials also have “user” which is the webknossos user id. That is not what is supposed to be passed to http basicauth…

Steps to test:

  • Explore a remote dataset with basic auth
  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Feb 21, 2023
@fm3 fm3 requested a review from normanrz February 21, 2023 14:36
@fm3 fm3 enabled auto-merge (squash) February 21, 2023 14:38
@fm3 fm3 merged commit df53e38 into master Feb 21, 2023
@fm3 fm3 deleted the basicauth-user branch February 21, 2023 14:54
hotzenklotz added a commit that referenced this pull request Feb 22, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into nav…
ef89a0e 
…bar-menu

* 'master' of github.com:scalableminds/webknossos:
  Fix style of connectome tab by restricting directory tree style (#6864)
  Remove legacy datasets tab and use new compact route (#6834)
  Fix basicauth for exploring remote http datasets (#6866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @normanrz