Add functions to get and set segment colors to the frontend API #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix a bug in the segment color picker where the color that was preselected after opening the picker was wrong.
daniel-wer
commented
Feb 15, 2023
| id: number, | ||
| customColors?: Array<number> | null | undefined, | ||
| customColors?: Array<Vector3> | null | undefined, |
There was a problem hiding this comment.
None of the callers uses this parameter which is why I changed its format. I think it's purely there to "mirror" the functionality of the convertCellIdToRGB shader function as pointed out in the comment above. Since the customColors are in RGB format in the shader as well, I figured it's fine to mirror that, here.
hotzenklotz
added a commit
that referenced
this pull request
Mar 6, 2023
…come_header_UI * 'master' of github.com:scalableminds/webknossos: (34 commits) Slim down view mode dropdown by using icons (#6900) Logging on password reset/change (#6901) When merging volume tracings, also merge segment lists (#6882) avoid spinner when switching tabs in dashboard (#6894) Upgrade Antd to v4.24 (#6865) Support n5 end-chunks with chunksize differing from metadata chunksize (#6890) Implement http range requests for HttpsSeekableByteChannel (#6869) new GH action for adding issues to project board Fix links in Changelog (#6881) adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879) Release 23.03.0 (#6880) Fix superUser being wrongly marked as organization owners (#6876) Followups for OME-TIFF export (#6874) Fix reload-precomputed-mesh functionality (#6875) Adds OME-TIFF export (#6838) Add evolutions 99,100 to migration guide (#6871) Add link to imprint and privacy to help menu (#6870) Annotation Locking Mechanism (#6819) Update deprecated antd <Menu> (#6860) Add functions to get and set segment colors to the frontend API (#6853) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a bug in the segment color picker where the color that was preselected after opening the picker was wrong.
The
hexToRgbutils function returned the color in [0, 255], but later it was assumed to be in [0, 1] and was scaled to 255 again. BecausehexToRgbwas only used for the segment color picker, I changed its return value to be in [0, 1] which we usually use in other related functions.URL of deployed dev instance (used for testing):
Steps to test:
webknossos.apiReady(3).then(async (api) => {console.log(api.data.getSegmentColor(<YOUR_SEGMENT_ID>))})to get the color of the segment via the api -> The color should be the previously selected color in RGB in the interval [0, 1]webknossos.apiReady(3).then(async (api) => {console.log(api.data.setSegmentColor(<YOUR_SEGMENT_ID>, [0, 1, 1]))})to set the color of the segment (and mesh) -> The segment and mesh should change their color to turquoiseIssues:
(Please delete unneeded items, merge only when none are left open)