Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbtool schema check stderr capturing #6830

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix dbtool schema check stderr capturing #6830

merged 2 commits into from
Feb 7, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 7, 2023

This should restore the schema difference output to the slack notification.
Also: clarify in logging which output comes from the dbtool (otherwise the bare Startup - ✨✨ Done was misleading)

Steps to test:

  • Create a schema mismatch by messing with your local db schema, e.g. inserting a new table
  • This difference should be included in the error logging on wk startup

Issues:

@fm3 fm3 enabled auto-merge (squash) February 7, 2023 16:46
@fm3 fm3 merged commit e2036fd into master Feb 7, 2023
@fm3 fm3 deleted the dbtool-stderr branch February 7, 2023 17:05
@fm3 fm3 changed the title Fix dbtool schema scheck stderr capturing Fix dbtool schema check stderr capturing Feb 8, 2023
hotzenklotz added a commit that referenced this pull request Feb 8, 2023
…a_owner

* 'master' of github.com:scalableminds/webknossos:
  Loki batched insert (#6831)
  Fix editable text style (#6799)
  Fix dbtool schema scheck stderr capturing (#6830)
  Release 23.02.1 (#6827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema mismatch details are no longer sent to slack
2 participants