Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing #6802

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix spacing #6802

merged 3 commits into from
Feb 2, 2023

Conversation

hotzenklotz
Copy link
Member

Small PR to fix some UI spacing issues that were bugging me:

  • The current mag in the status bar was no longer visible to me. Likely because the new font is slightly wider than the old one. Now it barely fits a 15" Macbook screen.
  • The Switch to this organization and return to dashboard buttons didn't fit next to each other anymore. Likely also because of the new, wider font. I stacked them above one another with some flex boxing.

image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Check layouting/CSS changes on your screen

Issues:

  • None

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Feb 1, 2023
philippotto
philippotto approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well for me, too 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) February 2, 2023 11:01
@hotzenklotz hotzenklotz merged commit d80ba0a into master Feb 2, 2023
@hotzenklotz hotzenklotz deleted the fix_spacing branch February 2, 2023 11:20
hotzenklotz added a commit that referenced this pull request Feb 2, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fix…
81139eb 
…_editable_text_style

* 'master' of github.com:scalableminds/webknossos:
  Fix spacing (#6802)
  Release 23.02.0 (#6801)
  Fix logo in Readme (#6805)
  Enforce Pricing for Team Sharing (#6776)
  applied PR feedback
  prevent proof reading tool from being unsed through keyboard shortcut
  disable proof reading tool
  use isFeatureAllowedByPricingPlan for SecuredRoute
  enforce pricing for creating precomputed meshes
  add isFeatureAllowedByPricingPlan helper function
  re-styled pricing alert
  Update frontend/javascripts/components/pricing_enforcers.tsx
  updated changelog
  add new blur component around certain paid features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzenklotz @philippotto