Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proofreading when mag 1 doesn't exist for segmentation layer #6795

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Fix proofreading when mag 1 doesn't exist for segmentation layer #6795

merged 3 commits into from
Jan 31, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 31, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I duplicated the test-agglomerate-ds, added another color layer (which has mag 1), downsampled the seg layer and removed mag 1 so that only mag 2 exists (therefore, color exists in mag 1 but the segmentation layer only in mag 2)
  • then I used the proofreading tool to merge segments (didn't work before in this constellation)
  • I also doublechecked that one cannot merge with segment 0

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 31, 2023
daniel-wer
daniel-wer approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes perfect sense to me 👍

@philippotto philippotto enabled auto-merge (squash) January 31, 2023 17:48
@philippotto philippotto merged commit e90eaf2 into master Jan 31, 2023
@philippotto philippotto deleted the fix-getRawDataCuboid branch January 31, 2023 17:49
hotzenklotz added a commit that referenced this pull request Feb 1, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fix…
1fe3d63 
…_editable_text_style

* 'master' of github.com:scalableminds/webknossos:
  Fix proofreading when mag 1 doesn't exist for segmentation layer (#6795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer