-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier folder creation and configurable target folder for dataset upload #6704
Conversation
…holder; when rightclicking placeholder a context menu will tell the user to rightclick a folder item instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Worked well during my testing, both for dataset upload and remote zarr import 👍
The backend part probably won't happen in this year. Merging this now could be confusing to users when the DS doesn't pop up in the desired folder. However, this can be confusing right now, too 🤔
Since the frontend gets to know whether the dataset needs to be converted, a simple toast/message could help to avoid confusion. It could state that this is not supported yet and that the dataset needs to be moved after the conversion.
Co-authored-by: Daniel <[email protected]>
…plain that specifying a target folder is not supported in that case
Good idea! Instead of showing a prompt, I used the antd form validation which also works nicely, I think. |
…bled property; don't make allowed teams required
…pt wording for access permissions to new folder concept
…s into folder-follow-up
@daniel-wer I updated the front-end to incorporate the newest changes by @fm3 so that the target folder also works with datasets which are converted after upload. The target folder must be specified now and the front-end ensures that the user may upload the DS to the folder by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, that datasets that need a conversion can be uploaded to a specific folder now, too.
During testing I noticed
- When selecting "Add Dataset" from a folder, the target folder is preselected which is nice. However, when trying to upload, webknossos complains that no target folder is selected (manually selecting the same folder fixes the issue). See screenshot
- The target folder preselection is also performed for folders the user doesn't have edit permissions for and which, therefore, couldn't be selected manually, because their entries are disabled
- [Optional] When selecting "Go to Dashboard" after a successful dataset upload, it would be cool to auto-activate the target folder so the user immediately sees the uploaded dataset
…m state for this to fix initial value bug
…add-folder-button
@daniel-wer Thank you for your testing feedback! I incorporated the first two points. I agree, the third point would be nice, but I decided against it for now due to the priority/cost ratio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as advertised 👍
The target folder functionality is currently front-end only (it simply uses the API to move the DS after the upload). This won't work if the dataset needs to be converted first. Not sure whether this should block the PR. The backend part probably won't happen in this year. Merging this now could be confusing to users when the DS doesn't pop up in the desired folder. However, this can be confusing right now, tooURL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)