add protected and private modifiers to DAO hierarchy #6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
added a commit
that referenced
this pull request
Dec 20, 2022
…cing * 'master' of github.com:scalableminds/webknossos: Automatically open (and close) quick select settings when labeling in… (#6706) Add Terms of Service Acceptance Concept (#6632) Fix crash in publication page and add error boundaries (#6700) temporarily disable vx related polling (#6702) add protected and private modifiers to DAO hierarchy (#6698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-generating Tables.scala from a changed SQL schema led to a ton of unneeded recompilation.
This PR adds protected/private access modifiers in the DAO hierarchy to make everything that has stuff from Tables.scala in the signature protected/private in the DAO scope. This was implicitly already the case for most methods. The exception was parse, where two non-private usages existed in associated DAOs (SharedAnnotationsDAO, UserTeamRolesDAO). I merged these into the main DAOs AnnotationsDAO and UserDAO respectively to avoid having to make parse public.
URL of deployed dev instance (used for testing):
Steps to test: