Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing failure in import of ngff zarr datasets with translation transforms #6621

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 9, 2022

not all Transformations in NGFF 0.4 have a scale attribute.

URL of deployed dev instance (used for testing):

Steps to test:

Issues:


@fm3 fm3 requested a review from frcroth November 9, 2022 14:01
@fm3 fm3 self-assigned this Nov 9, 2022
@@ -27,6 +27,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released

### Fixed
- Fixed importing a dataset from disk. [#6615](https://github.com/scalableminds/webknossos/pull/6615)
- Fixed importing NGFF Zarr datasets with translation transforms. [#6621](https://github.com/scalableminds/webknossos/pull/6621)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And identity, right?

@frcroth
Copy link
Member

frcroth commented Nov 10, 2022

The deployed dev instance does not seem to be working.

@fm3
Copy link
Member Author

fm3 commented Nov 10, 2022

The deployed dev instance does not seem to be working.

Sorry, forgot to install it, should be available now :)

@fm3 fm3 enabled auto-merge (squash) November 10, 2022 12:20
@fm3 fm3 merged commit 35c3673 into master Nov 10, 2022
@fm3 fm3 deleted the fix-ngff-translate branch November 10, 2022 12:39
hotzenklotz added a commit that referenced this pull request Nov 11, 2022
…cing

* 'master' of github.com:scalableminds/webknossos:
  Fix parsing failure during import of ngff zarr datasets with translation transforms (#6621)
  Fix rerender after each layer name keypress in dataset import view (#6628)
  Create a layer for each channel of NGFF-Zarr datasets (#6609)
  Fix screenshot tests (#6623)
  Fix importing a dataset from disk (#6615)
  Allow deleting annotation layers (#6593)
  Rephrased Error Messages (#6616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGFF Explorer: fails if non-scale coordinateTransformations are present
2 participants