Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid int overflows for agglomerate tree id #6472

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Avoid int overflows for agglomerate tree id #6472

merged 3 commits into from
Sep 16, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 15, 2022

Protobuf skeletons only support int tree ids, not long. We math.abs the id now as a hash function so that a unique deterministic tree color can be selected but no overflows occur, as the frontend won’t handle negative tree ids.

Steps to test:

  • load agglomerate skeletons for agglomerates with very large ids
  • they should show

Issues:


  • added changelog entry
  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 marked this pull request as ready for review September 16, 2022 07:53
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@fm3 fm3 enabled auto-merge (squash) September 16, 2022 07:55
@fm3 fm3 merged commit 4538404 into master Sep 16, 2022
@fm3 fm3 deleted the agglomerate-tree-id branch September 16, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agglomerate Skeleton request returned negative tree ids
2 participants