-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voxelytics frontend #6460
Voxelytics frontend #6460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test yet and only skimmed the new modules, but looks good overall 👍 will try to test now.
@@ -702,3 +703,166 @@ export type ZarrPrivateLink = { | |||
accessToken: string; | |||
expirationDateTime: number | null; | |||
}; | |||
|
|||
export enum VoxelyticsRunState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to lazy-import a vx bundle, it might be useful to add these types to a new module. In general, we should reorganize some code a bit (e.g., this module currently imports the store which imports the sagas which imports a big part of the code base). However, this is rather out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to refactor that in a coordinated effort. If moving these types in a separate file, we at least also need to move the vx-related functions from admin_rest_api.ts
to a separate file.
a comparison of the old and new bundle sizes would be interesting before we merge this. |
6.6M vs 7.2M uncompressed (calculated with Bundle splitting turns out to be quite difficult :-/ |
I had a look at the devtools on https://master.webknossos.xyz vs https://vxfrontend.webknossos.xyz/ and there the difference is 381 kB vs. 380 kB for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
It could be done, but we'd need to rework the code splitting config in webpack. We need to figure out how to assign stable names to the individual bundles (currently, hard-coded to |
* adds log routes * fixes log routes * fixes log routes * moar routes * Create unified json format for ObjectId * remove unused imports * fixes * works * Merge branch 'master' into vx-routes * schema * schema * lint * refactoring * Merge branch 'master' into objectid-json * pr feedback * merge * pr feedback * Merge remote-tracking branch 'origin/master' into vx-routes * rename tables * fixes * fixes * messages and conf * Merge remote-tracking branch 'origin/master' into vx-routes * fixes Elasticsearch polling and setup * lint * remove @Api annotation from VoxelyticsController * Merge branch 'master' into vx-routes * pr feedback * update snapshots * pr feedback * pr feedback * revert blanket-cors header * no cors in vx routes * Merge remote-tracking branch 'origin/master' into vx-routes * fixes log levels * pr feedback * format * move * changelog * Update app/models/voxelytics/VoxelyticsLogLevel.scala Co-authored-by: Florian M <[email protected]> * Merge branch 'master' into vx-routes * Voxelytics frontend (#6460) * wip voxelytics workflow viewer frontend * fixes JS code * stuff * styling * expose features.voxelyticsEnabled * revert changes to Application.scala * format * pr feedback * output ES2020 * styling * styling Co-authored-by: Florian M <[email protected]> * styling * merge * evolutions * Merge branch 'master' into vx-routes * Merge branch 'master' into vx-routes
Steps to test:
WORKFLOW_URL
env var tohttp://localhost:9000
DEFAULT_WEBKNOSSOS_URL
env var tohttp://localhost:9000
WORKFLOW_TOKEN
env var to a valid auth token in the above configured webKnossos instancevx voxelytics/connect/test/configs/segem_test_2d.yaml --cpu
fixes #6468
(Please delete unneeded items, merge only when none are left open)