-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter datasets by organization, use that in task creation view #6377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front-end lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend code looks mostly fine, I'd just like to have a Swagger annotation for the parameters of the datasetList
endpoint ✍️
@@ -10,6 +10,10 @@ object DefaultConverters { | |||
} | |||
} | |||
|
|||
implicit object StringToString extends Converter[String, String] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔
(Why is this needed? Doesn't do much harm, just wondering…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of Filters extracts the get parameters, and uses these Converters to type them. There wasn’t a string one before, and this implicit method was needed.
However, I guess we should stop using this method, and go for explicit get parameters, also allowing for standard swagger anotations. It may be that I can remove these converters then. I’ll have a look
@jstriebel I added swagger annotations and listed the parameters explicitly, including types. Please have another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, LGTM 👍
api/datasets
:organizationName: String
,onlyMyOrganization: Boolean
,uploaderId: String
Steps to test:
organizationName: String
,onlyMyOrganization: Boolean
,uploaderId: String
Issues: