Upgrade ThreeJS and use WebGL 2 #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is already a recommended configuration
…t-add-default-recommendation
…cient now since size cannot be altered later anymore)
This reverts commit c7089db.
|
@daniel-wer I think, the PR is ready for a second look. I fixed all the issues that are relevant to this PR and the screenshot tests should be good now, too. I'll probably have our team do some additional testing, too, to get a good coverage of different systems (hardware, OS, browser etc). |
daniel-wer
approved these changes
Aug 1, 2022
.circleci/not-on-master.sh
Outdated
| @@ -1,8 +1,8 @@ | |||
| #!/usr/bin/env bash | |||
| set -Eeuo pipefail | |||
|
|
|||
| if [ "${CIRCLE_BRANCH}" == "master" ]; then | |||
| # if [ "${CIRCLE_BRANCH}" == "master" ]; then | |||
There was a problem hiding this comment.
Reminder to re-enable this before merging
…onForCrossSections)
This reverts commit 4053cf8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The screenshots have slightly thicker borders (the red, green, blue ones) now apparently:
old:
new:
I'm not sure whether this is only in the screenshot tests or for the normal browser setup, too. However, I don't think that this is a blocker. Especially, because the pixel difference is so small that the screenshot tests pass.
URL of deployed dev instance (used for testing):
Todo:
Steps to test:
Also, try to test wk rather broad regarding rendering, but the following were changed during this PR which is why they should be tested with extra care:
Issues:
(Please delete unneeded items, merge only when none are left open)