Don't show error toast when dataset sharing token could not be acquired #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Jun 15, 2022
philippotto
added a commit
that referenced
this pull request
Jun 16, 2022
…ed (#6279) Co-authored-by: Daniel <[email protected]>
philippotto
added a commit
that referenced
this pull request
Jun 16, 2022
* Fix broken context menu in dataset-view-mode when no segmentation layer is visible (#6259) * fix broken context menu in dataset-view-mode when no segmentation layer is visible * update changelog * Fix benign error toast for public annotations and other improvements (#6271) * make modals lazy; don't show error toast when fetching token or teams failed; fix padding of share button * update changelog * rename makeModalLazy to makeComponentLazy; improve its typings and also use it for the ShareModalView, UserScriptsModal and MergeModalView * improve typing * don't try to fetch teams or token in sharing modal when not logged in * don't show error toast when dataset sharing token could not be acquired (#6279) Co-authored-by: Daniel <[email protected]> * update changelog for 22.06.1 Co-authored-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)
Updated (unreleased) changelogthe old changelog entry should describe it sufficiently 😅