Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution name in data request for backwards-compatibility #6196

Merged
merged 1 commit into from
May 9, 2022

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented May 9, 2022

There was still a left-over from the zoomStep/resolution renaming back-and-forth, leading to failures with wk-libs. Let's release this soon.

Follow-up from #6159

@jstriebel jstriebel requested a review from fm3 May 9, 2022 10:16
@jstriebel jstriebel self-assigned this May 9, 2022
@fm3 fm3 enabled auto-merge (squash) May 9, 2022 10:18
@jstriebel
Copy link
Contributor Author

PS: @fm3, do you have an idea if we could fail the build if an argument in the routes file is not accepted in the function? I guess the other way around is a normal case, but this way should lead to an error IMO.

@fm3
Copy link
Member

fm3 commented May 9, 2022

I would have expected the scala compiler to fail in this case, which is also why I didn’t catch the error in the first place. Unfortunately, I don’t think there is an easy way to fix this. We could write our own validation logic, but it would not be simple. Since this is the first time this has happened, I’d say it is not high-enoughp riority to build that.

Of course, if that specific route would have been called in the tests, an error should have come up. The back-end does not currently have great test coverage, that would be a whole nother package

@fm3 fm3 merged commit b832f98 into master May 9, 2022
@fm3 fm3 deleted the fix-backward-compatibility-resolution-data-request branch May 9, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants