-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Java Temp Files in task creation #6178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Props for digging into this, I think the solution is good. Maybe we should also add a comment about the bug in the code (e.g. in TempFileService
)? See my two comments below, besides this LGTM 👍
Thanks for your feedback! I implemented the suggestions and also noticed another bug, where slashes in the prefix would lead to wrong file paths (so I am removing those now). Could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: