Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to dataset list #6131

Merged
merged 9 commits into from
Apr 4, 2022
Merged

Small updates to dataset list #6131

merged 9 commits into from
Apr 4, 2022

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 31, 2022

This PR adds a few changes to the dataset list in the dashboard:

  • remove the isActive and isPublic columns to save screen space
  • changes to Allowed Teams column:
    • the isPublic information is now available in the Allowed Teams column
    • renamed the Allowed Teams column to Access Permissions, which I found more self-explanatory. Feedback welcome.
    • added antd table filter for Access Permissions, e.g. to filter a publicly shared dataset
    • restricted tag width and added ellipsis for long names
  • changes to data layers column:
    • changed the displayed tags from layer category to layer names as suggested by @normanrz , e.g. "color" --> "axons"
    • added antd table filter for data layer, e.g. to filter for all datasets with "synapse" layers/information
    • restricted tag width and added ellipsis for long names
  • Changes to tags column:
    • switched from a fixed width column to using max-width. In cases with no tags, the whole table should be narrower.

image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Test access permission column filters
  • Test data layers column filters
  • create some long team names
  • create some long tags
  • filter for public dataset (set one to public first)

Issues:

  • None

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Mar 31, 2022
@hotzenklotz hotzenklotz requested a review from philippotto March 31, 2022 13:02
philippotto and others added 4 commits March 31, 2022 15:06
…sos into filter_permissions

* 'filter_permissions' of github.com:scalableminds/webknossos:
  fix flow
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, looks good to me 👍

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@hotzenklotz hotzenklotz enabled auto-merge (squash) April 4, 2022 09:34
@hotzenklotz hotzenklotz merged commit ba87806 into master Apr 4, 2022
@hotzenklotz hotzenklotz deleted the filter_permissions branch April 4, 2022 09:59
hotzenklotz added a commit that referenced this pull request Apr 11, 2022
* master:
  Fix copy slice tool in mags other than mag 1 (#6130)
  Small updates to dataset list (#6131)
  Handle failing localStorage.setItem invocation (#6134)
  Bump node-forge from 1.2.1 to 1.3.0 (#6124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants