-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small updates to dataset list #6131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sos into filter_permissions * 'filter_permissions' of github.com:scalableminds/webknossos: fix flow
philippotto
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, looks good to me 👍
Co-authored-by: Philipp Otto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few changes to the dataset list in the dashboard:
isActive
andisPublic
columns to save screen spaceAllowed Teams column
:isPublic
information is now available in theAllowed Teams
columnAllowed Teams
column toAccess Permissions
, which I found more self-explanatory. Feedback welcome.Access Permissions
, e.g. to filter a publicly shared datasetdata layers
column:data layer
, e.g. to filter for all datasets with "synapse" layers/informationtags
column:max-width
. In cases with no tags, the whole table should be narrower.URL of deployed dev instance (used for testing):
Steps to test:
access permission
column filtersdata layers
column filtersIssues:
(Please delete unneeded items, merge only when none are left open)