Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify long-running RPC timeouts #6103

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Unify long-running RPC timeouts #6103

merged 3 commits into from
Mar 9, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 9, 2022

Remote calls between wk and datastore/tracingstore had different kind of timeouts (some the default of 2 min, some 30 min, some infinite). This PR introduces the withLongTimeout method for the RPC wrapper, and adds it to the RPCs that are potentially slow (basically everything that handles the content of potentially large skeletons or volume data).

Steps to test:

  • (will be hard to test without very large data)
  • downsample a large mag1 volume annotation, should not timeout

@fm3 fm3 added the backend label Mar 9, 2022
@fm3 fm3 self-assigned this Mar 9, 2022
@fm3 fm3 changed the title [WIP] Unify long-running RPC timeouts Unify long-running RPC timeouts Mar 9, 2022
@fm3 fm3 marked this pull request as ready for review March 9, 2022 13:28
@fm3 fm3 requested a review from leowe March 9, 2022 13:29
Copy link
Contributor

@leowe leowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fm3 fm3 enabled auto-merge (squash) March 9, 2022 13:41
@fm3 fm3 merged commit 766ac37 into master Mar 9, 2022
@fm3 fm3 deleted the long-running-rpcs branch March 9, 2022 13:55
hotzenklotz added a commit that referenced this pull request Mar 29, 2022
* master:
  fix docs formatting
  Remove experimental auto brush feature (#6107)
  Fix markdown issues in docs (#6105)
  Unify long-running RPC timeouts (#6103)
  Disallow deactivating users with active tasks (#6099)
  Add remote origin headers also in error case (#6098)
  Linking layers during upload no longer restricted to public datasets (#6097)
  Fix layer headers layout (#6087)
  Fix more docs links (#6095)
  Update datasets.md (#6094)
  More PR feedback for Docs (#6091)
  Updates to wK Docs (#5995)
  Connectome Tab (#5894)
  Fix duplicating annotations via toggling show archived annotations button and fix downsample modal rendering errors (#6058)
@fm3 fm3 mentioned this pull request Apr 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants