-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "hide/show other trees" to tree context-menu #6102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works mostly well 👍 I think, it's worth an entry in the changelog.
Some observations which are not blocking in my opinion, though:
- the context menu does not close when using the new item. it's a bit weird, but in line with most of the other items, since the actions are often used in succession (e.g., shuffle the tree color until it's good). so, it can probably stay as is. however, for the context menu on the group item, the behavior is different (it will close directly after using the entry).
- when using this action on a tree which is invisible, it will be turned visible, but all the other trees won't turn invisible. maybe acceptable, since one can just click again. can be reproduced with this state of trees:
@philippotto Updated the changeling :-)
Good catch. I fixed this. Now the context menu closes after clicking on the "Hide/Show" menu entry.
Yes, this is odd. But since I am relying on an existing functionality I will not changes that as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Co-authored-by: Philipp Otto <[email protected]>
There already is a functionality in webknossos to "Hide all inactive trees", i.e. toggle the visibility of all other trees but the currently selected one. This feature is bound to keyboard hotkey
2
.In this PR, I exposed this functionality through the right-click context menu for each tree/group.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)