-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensible scalebar values #6034
Sensible scalebar values #6034
Conversation
One open issue I could think of is that the scalebar will theoretically start to explode with scales over 10 km. Since we are not google earth I assume this is fine for now but I will add a switch to stop the scalebar from expanding infinitely in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Works well and the code looks solid, too 👍 I left some suggestions and I assume there is one small bug in the calculation of the width (which was probably already present in earlier versions). See my comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool :) looking forward to see this live!
…ssos into docs * 'docs' of github.com:scalableminds/webknossos: * 'master' of github.com:scalableminds/webknossos: Split cells via Min Cut (#5885) Clean up backend util package (#6048) Guard against empty saves (#6052) Time tracking: Do not fail on empty timespans list (#6051) Fix clip button changing position (#6050) Include ParamFailure values in error chains (#6045) Fix non-32-aligned bucket requests (#6047) Don't enforce save state when saving is triggered by a timeout and reduce tracing layout analytics event count (#5999) Bump cached-path-relative from 1.0.2 to 1.1.0 (#5994) Volume annotation download: zip with BEST_SPEED (#6036) Sensible scalebar values (#6034) Faster CircleCI builds (#6040) move to Google Analytics 4 (#6031) Fix nightly (fix tokens, upgrade puppeteer) (#6032) Add neuron reconstruction job backend and frontend part (#5922) Allow uploading multi-layer volume annotations (#6028)
* docs: Split cells via Min Cut (#5885) Clean up backend util package (#6048) Guard against empty saves (#6052) Time tracking: Do not fail on empty timespans list (#6051) Fix clip button changing position (#6050) Include ParamFailure values in error chains (#6045) Fix non-32-aligned bucket requests (#6047) Don't enforce save state when saving is triggered by a timeout and reduce tracing layout analytics event count (#5999) Bump cached-path-relative from 1.0.2 to 1.1.0 (#5994) Volume annotation download: zip with BEST_SPEED (#6036) Sensible scalebar values (#6034) Faster CircleCI builds (#6040) move to Google Analytics 4 (#6031) Fix nightly (fix tokens, upgrade puppeteer) (#6032) Add neuron reconstruction job backend and frontend part (#5922) Allow uploading multi-layer volume annotations (#6028)
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)