Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Download of Public Annotations While Logged Out #6001

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Allow Download of Public Annotations While Logged Out #6001

merged 1 commit into from
Jan 31, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 31, 2022

To support wk-libs example using public annotation

Steps to test:

  • set a dataset to public in dataset sharing settings
  • create an annotation on that dataset, set to public as well
  • open that annotation while logged out (e.g. private window)
  • download annotation, should yield zip instead of error

@fm3 fm3 added the backend label Jan 31, 2022
@fm3 fm3 requested a review from jstriebel January 31, 2022 15:01
@fm3 fm3 self-assigned this Jan 31, 2022
jstriebel
jstriebel approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast help! ❤️

@jstriebel jstriebel enabled auto-merge (squash) January 31, 2022 15:37
@jstriebel jstriebel merged commit 573b1a2 into master Jan 31, 2022
@jstriebel jstriebel deleted the allow-download-of-public branch January 31, 2022 15:46
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into docs
997527b 
* 'master' of github.com:scalableminds/webknossos:
  Add option to change active segement (#6006)
  ship expanded testdata (#6004)
  Allow Download of Public Annotations While Logged Out (#6001)
  Increase maximum bucket count limit for segmentation layers (#6000)
  Allow cancelling uploads (#5958)
  Store layer visibility with annotation (#5967)
  Fix async volume bugs (#5955)
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
@hotzenklotz
Merge branch 'delete_tree_shortcut' of github.com:scalableminds/webkn…
ed1cae1 
…ossos into delete_tree_shortcut

* 'delete_tree_shortcut' of github.com:scalableminds/webknossos:
  Add option to change active segement (#6006)
  ship expanded testdata (#6004)
  Allow Download of Public Annotations While Logged Out (#6001)
  Increase maximum bucket count limit for segmentation layers (#6000)
  Allow cancelling uploads (#5958)
  Store layer visibility with annotation (#5967)
  Fix async volume bugs (#5955)
  fix positioning of clip button (#5992)
  Honor mappingStatus when requesting to compute meshes ad-hoc (#5982)
  Add UI to globalize incomplete floodfill(s) (#5905)
  Add auto scaling for color layer (#5961)
  Fix placeholder resolutions for anisotropic layers with missing base resolutions (#5983)
  Fix dashboard refresh button behaviour (#5971)
  Update nanoid, trim-off-newlines and node-fetch (#5979)
  Add Arthur’s Alias in Build Notification Script (#5943)
  fix nml upload by providing process browser shim (#5987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @jstriebel