-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loaded meshes to sharing link #5993
Conversation
…ean up usages of Object.{values|keys} and improve flow typing
…ycam position change, DRY isosurface refresh code, refactor and rename changeActiveIsosurfaceCell to loadAdHocMesh, remove unused isosurface actions
@philippotto I have mostly tested the happy paths for this PR, but will do some more monkey testing next week. Still, this should be ready for a first review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work & refactoring 👍 It's a joy to read through these changes 🕺
I only have some concerns with processTaskWithPool
. Maybe they are unfounded (I didn't test my assumption), but my current understanding is that this needs some changes.. Happy to call about this, if you want 🤙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great adaptation of the pool "saga" 🥇 I couldn't get the sharing link to work, yet, though. I tried it with adhoc meshes and the URL doesn't seem to contain anything mesh related 🤔
…e meshes are loaded, adapt types accordingly, fix that reloading a mesh reloaded it with the current mapping instead of the original one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure, whether the new round is ready for review again, but especially the last commit seemed like a bigger chunk ready to review :) Great work refactoring this! I only left two suggestions. Let me know when/whether I should also test again :)
Thanks a lot! I addressed your feedback, would be great if you could do another test round. |
…d with different colors and patterns. The cause of this is unknown but appears in 12.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this PR slipped through on my side! I reviewed the latest commits and also did another testing round. Looks very solid 👍 Looking forward to see this live 🎉
…tests, temporarily enable nightly tests
…e, temporarily move new screenshot test to be the first one
…into upgrade-puppeteer-v13
…nds/webknossos into upgrade-puppeteer-v13
…ke sure compared buffers have the same length by converting them to png first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Thank you so much for taking care of the screenshot tests 🙏 I reviewed the latest commits and everything looks good!
threshold: 0.0, | ||
}); | ||
changedPixels = pixelmatch( | ||
// The buffers need to be converted to png before comparing them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this become necessary due to the update to pixelmatch
? Or has this always been an issue? Good catch, either way 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I read and experienced, pixelmatch
started to assert this in the new version but the problem existed before. Usually the difference was fairly small (which is why it mostly worked before), but I also encountered garbled diffs during my testing with other --use-gl
flags.
…s_lili * 'master' of github.com:scalableminds/webknossos: Add loaded meshes to sharing link (#5993)
Utils.values
which returns the correct type and should be the only spot where the $FlowIssue comment is needed. (_.values also seems to be correctly typed, but has unknown overhead)Array<number>
will lead to flow assuming a type ofnumber | any
for the mapped value argument 🤷 I did not systematically look for these occurrences, but I assume there are quite a few in our code, leading to less type security.URL of deployed dev instance (used for testing):
Steps to test:
refreshIsosurfaces
api methodwindow.webknossos.apiReady(3).then(api => api.data.refreshIsosurfaces());
Issues:
(Please delete unneeded items, merge only when none are left open)