Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection of datastore when uploading dataset #5952

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 11, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I hardcoded hasOnlyOneDatastoreOrNone to false so that the select UI becomes available when uploading a dataset
  • without this PR, the UI immediately crashed when clicking on the select box
  • with this PR, the dropdown does not crash anymore (upload works, too)
    I didn't test the select with multiple datastores (since I only have one set up currently), however, I think, the previous steps are already enough to show that the fix works.

(Please delete unneeded items, merge only when none are left open)

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix work out for me 🟢 . I also only tested this locally with my local datastore ans setting hasOnlyOneDatastoreOrNone to false.

The code is also fine 👍 .

Let's 🚢 to 🔪 the 🐛

@philippotto philippotto merged commit 460c748 into master Jan 14, 2022
@philippotto philippotto deleted the fix-datastore-selection branch January 14, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants