Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky bucket eviction tests by splitting/isolating them #5876

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

philippotto
Copy link
Member

I basically split the two relevant tests into separate modules so that ava's process isolation kicks in. I also tried to debug what exactly interferes with each other, but at some point I gave up 🤷

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • CI

Issues:

  • fixes flaky CI runs

(Please delete unneded items, merge only when none are left open)

  • Ready for review

@philippotto philippotto self-assigned this Nov 29, 2021
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@philippotto philippotto merged commit 102b4b0 into master Nov 30, 2021
@philippotto philippotto deleted the isolate-flaky-tests branch November 30, 2021 08:29
MichaelBuessemeyer pushed a commit that referenced this pull request Dec 22, 2021
* fix flaky bucket eviction tests by splitting/isolating them

* fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants