Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not poll jobs from dashboard if jobs are disabled #5761

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 6, 2021

URL of deployed dev instance (used for testing):

  • Jobs status is no longer polled if jobs are not enabled, avoiding backend logging spam
  • If jobs requests are sent despite jobs being enabled, the backend routes will return bad request

Steps to test:

  • open dashboard, see backend logging and/or browser network tab
  • no polling should happen
  • after enabling jobs, the polling should happen again

Issues:


@@ -59,7 +59,7 @@ function initTmpDB() {
.toString()
.trim(); // "trim" to remove the line break
if (dbName !== tempDbName) {
console.log("Wrong dbName");
console.log("Wrong temporary dbName, got", dbName, "expected", tempDbName);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slipped in here, it’s a small addition to the logging for debugging the diff schema script in production

@fm3 fm3 requested a review from MichaelBuessemeyer October 7, 2021 09:36
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend looks good to me :)

Thanks for fixing this 🔧

@fm3 fm3 enabled auto-merge (squash) October 7, 2021 11:13
@fm3 fm3 disabled auto-merge October 7, 2021 11:30
@fm3 fm3 merged commit 6acbfa7 into master Oct 11, 2021
@fm3 fm3 deleted the jobs-polling branch October 11, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job list should only be polled by dashboard if jobsEnabled
2 participants