Delay opening context menu to support windows again #5756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows behaves very strangely when it comes to the context menu. The same right-click to open the context menu also somehow reaches the overlay of the context menu, although the context menu isn't even rendered by React at this moment. Additionally, this occurs on all browsers on windows and on no other operating system. The browsers under windows I tested were: Firefox, Chrome, and Opera.
To prevent this weird behaviour I delayed the state change, which causes the context menu to render. This circumvents the behaviour for all tested windows browsers and the code still works on Linux + firefox for me.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment