Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips for settings in left sidebar #5673

Merged
merged 7 commits into from
Aug 19, 2021
Merged

Add tooltips for settings in left sidebar #5673

merged 7 commits into from
Aug 19, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 13, 2021 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • open view mode, annotation mode (orthogonal, flight), with and without volume
  • hover over settings labels, tooltips should be explanatory

Issues:

@fm3 fm3 self-assigned this Aug 13, 2021
@fm3 fm3 changed the title [WIP] Add tooltips for settings in left sidebar Add tooltips for settings in left sidebar Aug 16, 2021
@fm3 fm3 marked this pull request as ready for review August 16, 2021 07:59
@fm3 fm3 requested a review from philippotto August 16, 2021 07:59
philippotto
philippotto requested changes Aug 19, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I only have one nitpick :)

frontend/javascripts/oxalis/view/left-border-tabs/controls_and_rendering_settings_tab.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/controls_and_rendering_settings_tab.js Outdated Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) August 19, 2021 10:42
@fm3 fm3 merged commit f65d4a0 into master Aug 19, 2021
@fm3 fm3 deleted the more-tooltips branch August 19, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explaining tooltips for all settings in left sidebar
2 participants
@fm3 @philippotto