Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuclei inferral UI #5669

Merged
merged 17 commits into from
Aug 24, 2021
Merged

Add nuclei inferral UI #5669

merged 17 commits into from
Aug 24, 2021

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 12, 2021

This PR adds a rather simple UI to start a nuclei inferral job for a dataset

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • setup a local wk-worker
  • open a dataset with a single color layer in view mode or a tracing. There go to the info tab and use the "Permium Features" Dropdown to open the nuclei inferral modal. In the modal, the start button should directly be available, as there is only one color layer. Starting the job should work.
  • Now do the same for a dataset with multiple color layers. This time the modal should have a select for the user to choose the color layer that should be used for the nuclei inferral.

Issues:


@MichaelBuessemeyer MichaelBuessemeyer changed the title Add nuclei inferral ui Add nuclei inferral UI Aug 12, 2021
conf/application.conf Outdated Show resolved Hide resolved
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for building this UI 👍 As I already mentioned via slack, I took the liberty to iterate a bit on the PR and think that it's good to merge now. Please have another look at my commits and merge if everything looks good :)

Copy link
Contributor Author

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking action and doing the required changes yourself 🚀.

I only found a few minor UI things :)

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto Shall I do the changes or do you want to do them?

@philippotto
Copy link
Member

@philippotto Shall I do the changes or do you want to do them?

Would be great if you can squeeze it in :)

@MichaelBuessemeyer
Copy link
Contributor Author

MichaelBuessemeyer commented Aug 24, 2021

I just squeezed this in. Could you please check the changes @philippotto

@philippotto
Copy link
Member

Awesome! Thanks a lot 👨‍🎤

@philippotto philippotto enabled auto-merge (squash) August 24, 2021 08:52
@philippotto philippotto merged commit 81e7eea into master Aug 24, 2021
@philippotto philippotto deleted the add-nuclei-inferral-ui branch August 24, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI to trigger nuclei inferral worker job
3 participants