-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nuclei inferral UI #5669
Add nuclei inferral UI #5669
Conversation
6636e80
to
733d887
Compare
…utton if DS does not support job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for building this UI 👍 As I already mentioned via slack, I took the liberty to iterate a bit on the PR and think that it's good to merge now. Please have another look at my commits and merge if everything looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking action and doing the required changes yourself 🚀.
I only found a few minor UI things :)
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/nuclei_inferral_modal.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/nuclei_inferral_modal.js
Outdated
Show resolved
Hide resolved
@philippotto Shall I do the changes or do you want to do them? |
Would be great if you can squeeze it in :) |
I just squeezed this in. Could you please check the changes @philippotto |
Awesome! Thanks a lot 👨🎤 |
This PR adds a rather simple UI to start a nuclei inferral job for a dataset
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment