Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occluded login field #5577

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Fix occluded login field #5577

merged 4 commits into from
Jun 22, 2021

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Jun 18, 2021

This PR fixes a bug that prevented one from focusing a login field when being prompted to login with the "does not exist or could not be accessed. You may need to log in.” toast after trying to open a dataset without being logged in.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • log out / don't log in
  • open a dataset (view mode)
  • you should be prompted to log in and be able to do so

Issues:


Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🦖

@philippotto philippotto enabled auto-merge (squash) June 22, 2021 12:50
@philippotto philippotto merged commit 8f71526 into master Jun 22, 2021
@fm3 fm3 deleted the fix-occluded-login-field branch June 22, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When dataset cannot be accessed, canvas element occludes login field
2 participants