Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset upload: Fix special case in common prefix handling #5534

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Dataset upload: Fix special case in common prefix handling #5534

merged 4 commits into from
Jun 7, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 1, 2021 •
edited
Loading

When uploading a single file inside a zipfile, the common prefix handling ran into a bug, breaking the whole upload. This is fixed here.

Steps to test:

  • set jobsEnabled = true (no need to set up worker)
  • create zip file with single tif inside
  • upload that as dataset, no exception should be logged (only that the worker can’t be reached, if not set up)

Issues:

@fm3 fm3 self-assigned this Jun 1, 2021
@fm3 fm3 requested a review from youri-k June 1, 2021 07:20
youri-k
youri-k approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

@fm3 fm3 merged commit bc56bca into master Jun 7, 2021
@fm3 fm3 deleted the upload-common-prefix branch June 7, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset upload: null pointer exeption for zip with just one file
2 participants
@fm3 @youri-k