-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual pass state for long-running jobs #5530
Conversation
@youri-k I would like to add a line to the evolution setting the manualState to FAILURE for all existing jobs where the celery state is also FAILURE (because we don’t want to repair all old jobs). Since you are more familiar with json in SQL, could you give me a pointer there? No hurry. @philippotto I incorporated your feedback :) Another question: Do you think we should make this feature opt-in? (e.g. add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Front-end looks great! However, I added some comments regarding the typing which we should harden a bit to make the job handling more robust. The typing was already not optimal before this PR, but I think we should use the chance now to improve it :)
@philippotto Thanks for your feedback! :) Could you have another look? |
I hope this line from the evolution 57 is helpful:
This sets the layer's I really like this cheat sheet, where all the operators are explained: https://devhints.io/postgresql-json Hope this helps, but you can ping me again if something does not work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Front-end looks top notch 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend and SQL LGTM 🎉
Shows
convert_to_wkw
jobs that failed as “Manual“ (meaning an admin will try to repair this job), unless an admin has alreadyset the job’smanualState
toSUCCESS
orFAILURE
in the database.Steps to test:
Note:
I am unsure about the wording (e.g. the displayed name “Manual” for that new state), and the tooltips. Feedback welcome :)
Issues: