Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relabel too-high tree ids in backend #5484

Merged
merged 3 commits into from
May 12, 2021
Merged

Relabel too-high tree ids in backend #5484

merged 3 commits into from
May 12, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 11, 2021 •
edited
Loading

Workaround for #5009

URL of deployed dev instance (used for testing):

Steps to test:

  • upload nml with huge tree ids (>2^20)
  • should work (upload should remap the ids)
  • upload nml with normal tree ids should not be noticeably slower

Issues:

@fm3 fm3 self-assigned this May 11, 2021
@fm3 fm3 changed the title [WIP] relabel too-high tree ids in backend Relabel too-high tree ids in backend May 11, 2021
@fm3 fm3 requested a review from youri-k May 11, 2021 07:01
@fm3 fm3 marked this pull request as ready for review May 11, 2021 07:01
youri-k
youri-k approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🎉

Did you measure the performance impact? I feel like this shouldn't be a huge deal, but I don't know about real world tree counts.

@fm3 fm3 merged commit f41f4ae into master May 12, 2021
@fm3 fm3 deleted the relabel-tree-ids branch May 12, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend import should relabel trees with id > 1048576
2 participants
@fm3 @youri-k