Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight active tree and active node in comment tab #5461

Merged
merged 3 commits into from
May 19, 2021
Merged

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented May 5, 2021

Highlights the active tree and active node in the comment tab with a background color similar to the active tree in the tree tab.

Screenshot 2021-05-05 at 15 53 06

Screenshot 2021-05-05 at 15 53 12


@normanrz normanrz requested review from daniel-wer and philippotto May 5, 2021 16:46
@normanrz normanrz self-assigned this May 5, 2021
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) As far as I can see, this shouldn't interfere with comment links (#<node_id> to link to another node) as those links have the same blue color as the node id in front of comments which is also still visible 👍

@philippotto
Copy link
Member

Looks good! However, the background color makes the suboptimal vertical alignment more prominent. Maybe this is easy to fix. If not, should be fine for now, too.

@normanrz
Copy link
Member Author

Next round with adjusted centering.

Screenshot 2021-05-18 at 18 27 52

Screenshot 2021-05-18 at 18 27 59

I also increased the height of each comment entry to 24, which is the same as in the tree tab.
And, I removed the bold selected comment, because that is redundant with the colored background. wdyt?

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀

@normanrz normanrz merged commit 5192775 into master May 19, 2021
@normanrz normanrz deleted the active-comment branch May 19, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants