Only upload to datastores that allow upload #5404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where dataset uploads were sent to the wrong datastore (first in list, regardless of allowsUpload), and thus failed.
I’m a bit confused why this bug didn’t occur before. The datastore list from the server is ordered by name, so the “correct” one, webknossos.org is sent last, but the old code took the first.regression introduced in #5350 (for explanation see comment below)Steps to test: