Fix corruption of skeleton when using CTRL+Rightclick in empty tree #5385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug has two facets:
addNode
reducer helper simply added a node when being told so and only created an edge, if a node was selected. This means, if no node is selected (for whatever reason), corruption can ensue when the tree is not-empty. This should not happen in theory, but (1) provoked this scenario.To fix this bug, I did 2 things:
addNode
code so that the corruption cannot happen even if the circumstances would provoke it. The reducer would simply do a noop instead (and log an error message to the console).URL of deployed dev instance (used for testing):
Steps to test:
Issues: