Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel content reorganization + Control/Tool rework #5384

Merged
merged 227 commits into from
Jul 2, 2021

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Apr 8, 2021

URL of deployed dev instance (used for testing):

Steps to test:

  • Look at the checklist below and check whether the panels/tabs have the content as described in the list.

  • Please also check the (basic) functionality of the panel elements / settings.

  • I had quite a lot of merging conflicts relating the dark mode pr / css. This needs to be tested, so nothing breaks because of this PR.

Issues:


@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review June 4, 2021 15:17
@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto I don't remember whether I notified you, but I think I applied all feedback from last friday. Could you please take another look and tell me, whether this state is ok give to users to ask for feedback?
Thanks :) 🙏

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) only left some nitpicks

@philippotto philippotto changed the title [WIP] Panel content reorganization Panel content reorganization + Control/Tool rework Jun 7, 2021
@philippotto
Copy link
Member

philippotto commented Jun 7, 2021

  • superfluous divider in context menu when opening a dataset with a segmentation in view mode (@philippotto)
  • when soma-clicking AND merger mode are enabled, the border look weird (there is still some radius between this buttons?)
  • create-new-tree icon needs to be changed (@philippotto)
  • "Layer" to "Layers"
  • edit icon next to "active segment id" etc. could be a bit more subtle and have better padding (@philippotto)
  • padding-top of skeleton-tab still seems to be too big
  • "not all layers visible" still looks a bit weird. also, the icon pushes everything further down which makes the the other switch-buttons hard to use
    • <-- I fiddled a bit with this and think that we might not even need this. The icon has always been quite subtle. I'm not sure if there is a high value in it. Alternatively, a span in the toolbar à la "1/3 Layers visible" might be a better solution. But I would defer this until we deem this necessary.

To discuss (let's discuss this after we got some feedback):

  • the "volume" tab is gone now. still not sure, whether people will easily cope.

@philippotto
Copy link
Member

I think I pushed a solution for all items I mentioned above. Feel free to review my latest commits. I used the existing antd-legacy-group CSS class and removed the one you added, as the existing class seems to work better regarding the removal of the border-radius. I hope, I didn't oversee any regressions.

Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through many of the documentation changes and modals texts. In some cases I doubled checked with Grammarly.

docs/skeleton_annotation.md Outdated Show resolved Hide resolved
docs/keyboard_shortcuts.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
@MichaelBuessemeyer
Copy link
Contributor Author

I think I pushed a solution for all items I mentioned above. Feel free to review my latest commits. I used the existing antd-legacy-group CSS class and removed the one you added, as the existing class seems to work better regarding the removal of the border-radius. I hope, I didn't oversee any regressions.

Thanks for doing that :). I took a look at your changes and they look alright to me :)
I added a small fix, that if only the soma clicking mode is active, the border on the right side of the button was not shown / not blue by simply adding a z-index: 1 to the button if it is active. At least this solved the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize content of panels in core UI
3 participants