-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel content reorganization + Control/Tool rework #5384
Conversation
…sible base layouts
@philippotto I don't remember whether I notified you, but I think I applied all feedback from last friday. Could you please take another look and tell me, whether this state is ok give to users to ask for feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :) only left some nitpicks
To discuss (let's discuss this after we got some feedback):
|
I think I pushed a solution for all items I mentioned above. Feel free to review my latest commits. I used the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through many of the documentation changes and modals texts. In some cases I doubled checked with Grammarly.
frontend/javascripts/oxalis/view/novel_user_experiences/01-present-modern-controls.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/novel_user_experiences/01-present-modern-controls.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/novel_user_experiences/01-present-modern-controls.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/novel_user_experiences/01-present-modern-controls.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Herold <[email protected]> Co-authored-by: Philipp Otto <[email protected]>
Thanks for doing that :). I took a look at your changes and they look alright to me :) |
…el-content-reorganization
…el-content-reorganization
URL of deployed dev instance (used for testing):
Steps to test:
Look at the checklist below and check whether the panels/tabs have the content as described in the list.
Please also check the (basic) functionality of the panel elements / settings.
I had quite a lot of merging conflicts relating the dark mode pr / css. This needs to be tested, so nothing breaks because of this PR.
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment