Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-fill all available recommended settings to task type form #5341

Merged
merged 5 commits into from
Apr 7, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 25, 2021

If there is already a non-null recommendation-configuration, don't add the defaults.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • edit the default task type and add a recommended configuration
  • use the "remove" buttons to edit the recommended configuration
  • save task type and re-open the edit page
  • the recommended configuration should look exactly as before (i.e., no additional attributes should be added)
  • disabling the recommendation, saving + reloading, re-enabling the recommendation should show all available properties again

Issues:


@philippotto philippotto self-assigned this Mar 25, 2021
@philippotto
Copy link
Member Author

@MichaelBuessemeyer ping :)

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as described 👍

There is just one small thing flow is complaining about. I left a suggestion that is hopefully "pretty" :)

And thanks for the detailed testing steps. They made pretty easy to check.

@philippotto philippotto enabled auto-merge (squash) April 7, 2021 11:20
@philippotto philippotto merged commit a5cfea7 into master Apr 7, 2021
@philippotto philippotto deleted the dont-add-default-recommendation branch April 7, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task Type form re-fills all available recommended settings
2 participants