Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading NML via file picker #5308

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Fix uploading NML via file picker #5308

merged 3 commits into from
Mar 22, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 19, 2021

Uploading NMLs via file picker was broken (only drag’n’drop still worked)

URL of deployed dev instance (used for testing):

Steps to test:

  • Go to “Dashboard / My Annotations” tab
  • Click “Upload Annotation(s)”
  • Click blue “inbox” symbol
  • File picker should let you pick NMLs
  • uploading them should create annotations
  • Drag’n’Drop should also still work

Issues:

@fm3 fm3 requested a review from philippotto March 19, 2021 10:42
@fm3 fm3 self-assigned this Mar 19, 2021
philippotto
philippotto approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Fix looks and works great. Thank you for tackling this 🚀

@philippotto philippotto mentioned this pull request Mar 22, 2021
Merged
3 tasks
@fm3 fm3 enabled auto-merge (squash) March 22, 2021 15:17
@fm3 fm3 merged commit c58dafa into master Mar 22, 2021
@fm3 fm3 deleted the nml-upload-click branch May 3, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NML Upload modal no longer opens file picker
2 participants
@fm3 @philippotto