Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Experience Domains By Organization #5149

Merged
merged 8 commits into from
Feb 11, 2021
Merged

Separate Experience Domains By Organization #5149

merged 8 commits into from
Feb 11, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 9, 2021 •
edited
Loading

Steps to test:

  • Create tasks, set user experiences to user, in both cases, the experiences should show up in suggestions next time
  • set up second organization (e.g. via isDemoInstance=true), repeat.
  • experience domains should only be shown if logged into the orga they were created in

Issues:

@fm3 fm3 self-assigned this Feb 9, 2021
@fm3 fm3 changed the title [WIP] Separate Experience Domains By Organization Separate Experience Domains By Organization Feb 10, 2021
@fm3 fm3 marked this pull request as ready for review February 10, 2021 10:26
@fm3 fm3 requested a review from youri-k February 10, 2021 10:26
@fm3 fm3 mentioned this pull request Feb 10, 2021
Merged
3 tasks
youri-k
youri-k approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 1a06774 into master Feb 11, 2021
@fm3 fm3 deleted the orga-experience branch February 11, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate ExperienceDomains by organization
2 participants
@fm3 @youri-k