-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix histogram scale #4926
Fix histogram scale #4926
Conversation
After a discussion, we decided to use a linear scale 📈 |
@daniel-wer I got an exciting update. The scale is now linear and there are now even values on the y-axis 🤯 Could you please check out my changes? |
A quick internal discussion stated that we do not need the y-axis as the values are sampled and as the scale now is linear (which is what a user should expect) Nevertheless, could you please check out this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MichaelBuessemeyer for fixing this and reacting dynamically to the feedback others and I gave you 🙏
One weird thing I noticed on this branch, but not on master. At first the histogram line is thin, but when moving a histogram handle for the first time, the line becomes thicker all of a sudden and there's also a line at the bottom. See this gif:
Co-authored-by: Daniel <[email protected]>
…ssos into fix-histogram-scale
Oh, thanks for finding this bug. This was caused, because the canvas always used the same path. Refreshing was done in the drawYAxis method. I just added using a new path directly to the beginning of the drawHistogram method to fix this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find with the fix for the double line drawing bug 💯
This PR fixes the histogram scale. Previously we downscaled the data before applying the logarithm. This leads to a linear scale.
With this fix, the logarithm is applied before scaling the data to the histogram height.
During testing, I found 2 errors in the console produced by the new downscaling modal added by the multi-resolution PR. I just fixed those on the fly.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment