Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put dataset permissions in sharing tab #4763

Merged
merged 7 commits into from
Aug 13, 2020
Merged

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Aug 12, 2020

This PR moves a dataset's permission settings to the Sharing & Permissions tab.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • go to the editing view of a dataset
  • there should be a "Sharing & Permissions" tab
  • there should be the input field for teams that are allowed to access the dataset
  • in the "Metadata" tab should be no such input field

Issues:


@philippotto
Copy link
Member

Very cool! However, I noticed that the "warning" icon which appears when one doesn't have any "allowed teams" assigned is shown in the wrong tab title. See screenshot:

image

Could you please move that icon to the sharing & permission tab? Other than that, the PR looks fine to me!

@grittaweisheit
Copy link
Contributor Author

Sure! I totally didn't think about this icon. It should now be in the right position.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Please update the changelog before merging, though :)

@philippotto
Copy link
Member

(btw, you don't need to assign the good first issue label to the PR, as we typically use that only for filtering the issues and not the PRs)

@grittaweisheit grittaweisheit merged commit c7a3685 into master Aug 13, 2020
@philippotto philippotto deleted the dataset-permission-tab branch August 13, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset Permission should be in separate tab
2 participants