Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont warn if team has transitive dataset access #4711

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Dont warn if team has transitive dataset access #4711

merged 6 commits into from
Jul 20, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 13, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create two users + teams so that
  • team A is a subteam of organization team (meaning all its members are also members of the orga team)
  • team B is not a subteam of organization team (meaning there is a user in team B but not in the orga team)
  • give only the orga team access to a dataset
  • create task for team A → access warning should not be shown
  • create tsk for team B → access warning should be shown

Issues:

  • Ready for review

@fm3 fm3 added the backend label Jul 13, 2020
@fm3 fm3 requested a review from youri-k July 13, 2020 09:52
@fm3 fm3 self-assigned this Jul 13, 2020
youri-k
youri-k approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code and after fixing the small typo, everything worked perfectly 🎉

@fm3 fm3 added the automerge label Jul 20, 2020
@bulldozer-boy bulldozer-boy bot merged commit bcb75e2 into master Jul 20, 2020
@bulldozer-boy bulldozer-boy bot deleted the task-no-warning-if-subteam branch July 20, 2020 09:34
@fm3 fm3 mentioned this pull request Aug 5, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don’t show dataset access warning in case of transitive access
2 participants
@fm3 @youri-k