Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Server Time in Error Replies #4707

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Include Server Time in Error Replies #4707

merged 2 commits into from
Jul 9, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 8, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • trigger request that fails with error chain (e.g. I added _ <- Fox.failure("nope") to DataSet.findOne and then clicked create skeleton annotation on a dataset
  • server time should be included in the toast (behind “show more information”)

Issues:


@fm3 fm3 added the backend label Jul 8, 2020
@fm3 fm3 self-assigned this Jul 8, 2020
@fm3 fm3 requested a review from youri-k July 8, 2020 12:16
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 4fe8507 into master Jul 9, 2020
@fm3 fm3 deleted the errorchain-time branch July 9, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include server time in error replies
2 participants