Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Zero Admins in Organization #4698

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Prevent Zero Admins in Organization #4698

merged 5 commits into from
Jul 8, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 6, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • promote & depromote second user to/from admin, should still work
  • try depromote yourself if you are the only admin in organization, should result in error toast

Issues:

@fm3 fm3 added the backend label Jul 6, 2020
@fm3 fm3 self-assigned this Jul 6, 2020
@fm3 fm3 requested a review from youri-k July 6, 2020 13:03
youri-k
youri-k approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 added the automerge label Jul 8, 2020
@bulldozer-boy bulldozer-boy bot merged commit aa436e8 into master Jul 8, 2020
@bulldozer-boy bulldozer-boy bot deleted the prevent-zero-admins branch July 8, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce at least one admin per organization
2 participants
@fm3 @youri-k