Allow deleting datasets on disk

[fm3]

Adds new datastore route DELETE /datasets/:organizationName/:dataSetName/deleteOnDisk (use with care)
Adds a tab to dataset edit view, where this route can be triggered

URL of deployed dev instance (used for testing):

• https://___.webknossos.xyz

Steps to test:

• backend: test route DELETE /datasets/:organizationName/:dataSetName/deleteOnDisk (with admin token)
• frontend: check out new view, hit the button, dataset should be moved to .trash directory within organization datasets directory. Should be one after refresh

Open Questions:

• how to hide this for non-admins? (how to pass user to view as prop?)
• how to trigger dataset list refresh on dashboard after redirect

Issues:

• fixes enable deleting datasets from UI #4628

---

• Updated (unreleased) changelog
• Updated documentation if applicable
• Adapted wk-connect if datastore API changes
• Needs datastore update after deployment
• Ready for review

[MichaelBuessemeyer]

@fm3 Thanks a lot for also doing the frontend part 🚀 -> I did not check the backend part :)

I found only a few minor things to improve and while trying out my suggestions I just pushed them. I hope this is fine 🙈:

• We generally spell "dataset" in lowercase without capitalizing the s. Could you please correct this to have a consistent spelling?

And I noticed one additional thing:
When a dataset is deleted, it is still listed on the dashboard, which shouldn't be the case. Reloading wk does only solve this issue after some time. Maybe the backend is still deleting the dataset or the dataset is still cached or something like that but it is only removed from the dataset list after some time. :/
@fm3 could you please check whether this is due to the backend?

[fm3]

Thanks a lot for looking at this and even implementing the suggestions! 🎉
Yes, the backend will only notice the now-missing dataset upon the next inbox check (runs once per minute).
The Refresh button above the dataset list would also cause an inbox check, leading to the list being refreshed. Maybe we can trigger this action also during the deletion before redirecting.
But even then, the front-end shows a cached version of the dataset list until the next refresh, compare #4640
Do you have any ideas how we could solve this for the deletion?

[daniel-wer]

@fm3 Yes, it should be possible to trigger a refresh before redirecting and there should also be a way to show the newest set of datasets, because that's what happens when the "Refresh" button is clicked by the user. I'll have a look at the code :)

[youri-k]

Tested and works :)
Backend Code LGTM

[daniel-wer]

@fm3 The dataset list should show updated results after deleting a dataset now :)

Regarding the admin-only ToDo - Who should actually have access to the Import/Edit view at all? At a quick glance I didn't see any restrictions (apart from that the user needs access to the dataset).

[fm3]

dataset managers should see the links pointing there for all datasets; team managers should see them for the datasets their teams have access to, admins should see them for all datasets. I think this is already the case.
only admins should be allowed to delete

[MichaelBuessemeyer]

ToDos for me:

dataset managers should see the links pointing there for all datasets; team managers should see them for the datasets their teams have access to, admins should see them for all datasets. I think this is already the case.

• check this

only admins should be allowed to delete

• implement this

[MichaelBuessemeyer]

@fm3 The dataset list should show updated results after deleting a dataset now :)

works perfectly 👌

[MichaelBuessemeyer]

@daniel-wer Could you please check my latest frontend changes?

After this, the PR should be ready to go 🚢

[MichaelBuessemeyer]

I just had a look at the description.

• Updated documentation if applicable
• Adapted wk-connect if datastore API changes

@fm3 is updating wk-connect still a thing to do? I'll have a look at the docs

[daniel-wer]

Frontend changes look good, thanks for taking this over 👍

[fm3]

I added it to wk-connect’s issue tracker at scalableminds/webknossos-connect#22
I don’t think it has to be implemented there right away.