Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When exploring dataset layer, use previous category if available #4694

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 6, 2020

If an existing datasource-properties.json contains information about layer category, use it.
This occurred because there are now users with 16-bit color layers (not named “color”). There the guessed category was wrong, mixing up the datasource properties, even though correct information had been supplied on disk.

Steps to test:

  • Have a dataset with a 16-bit color layer not named color, write correct datasource-properties.json to disk
  • in the (advanced) “edit” view in wk for this dataset there should not be the wrongly inferred category “segmentation” but it should keep “color”.

Issues:


@fm3 fm3 self-assigned this Jul 6, 2020
@fm3 fm3 requested a review from youri-k July 6, 2020 10:56
@fm3 fm3 added the backend label Jul 6, 2020
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@fm3 fm3 merged commit 91a69d3 into master Jul 8, 2020
@fm3 fm3 deleted the explore-layer-use-prev-category branch July 8, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong layer type guessed despite correct one being in properties json
2 participants