Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that accessed data is always non-negative in shader #4571

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Ensure that accessed data is always non-negative in shader #4571

merged 4 commits into from
Apr 29, 2020

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 24, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I'll run a screenshot test

Issues:

@philippotto philippotto requested a review from daniel-wer April 29, 2020 12:52
@philippotto
Copy link
Member Author

Screenshot tests ran successfully on my computer 🎉

daniel-wer
daniel-wer approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, were you able to test this with the dataset that triggered the bug as well? 👍

@philippotto
Copy link
Member Author

LGTM, were you able to test this with the dataset that triggered the bug as well?

Yes, I developed the fix with the shader editor on that DS :)

@philippotto philippotto self-assigned this Apr 29, 2020
@bulldozer-boy bulldozer-boy bot merged commit 7e3e3da into master Apr 29, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-rendering-of-negative-data branch April 29, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative data in float is rendered incorrectly
2 participants
@philippotto @daniel-wer